[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v9 02/16] python: Reduce strictness of pylint's duplicate-code ch
From: |
Emanuele Giuseppe Esposito |
Subject: |
[PATCH v9 02/16] python: Reduce strictness of pylint's duplicate-code check |
Date: |
Mon, 9 Aug 2021 11:01:00 +0200 |
From: John Snow <jsnow@redhat.com>
Pylint prior to 2.8.3 (We pin at >= 2.8.0) includes function and method
signatures as part of its duplicate checking algorithm. This check does
not listen to pragmas, so the only way to disable it is to turn it off
completely or increase the minimum duplicate lines so that it doesn't
trigger for functions with long, multi-line signatures.
When we decide to upgrade to pylint 2.8.3 or greater, we will be able to
use 'ignore-signatures = true' to the config instead.
I'd prefer not to keep us on the very bleeding edge of pylint if I can
help it -- 2.8.3 came out only three days ago at time of writing.
See: https://github.com/PyCQA/pylint/pull/4474
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Acked-by: John Snow <jsnow@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
python/setup.cfg | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/python/setup.cfg b/python/setup.cfg
index 14bab90288..83909c1c97 100644
--- a/python/setup.cfg
+++ b/python/setup.cfg
@@ -105,6 +105,11 @@ good-names=i,
# Ignore imports when computing similarities.
ignore-imports=yes
+# Minimum lines number of a similarity.
+# TODO: Remove after we opt in to Pylint 2.8.3. See commit msg.
+min-similarity-lines=6
+
+
[isort]
force_grid_wrap=4
force_sort_within_sections=True
--
2.31.1
- [PATCH v9 00/16] qemu_iotests: improve debugging options, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 01/16] python: qemu: add timer parameter for qmp.accept socket, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 03/16] python: qemu: pass the wrapper field from QEMUQtestmachine to QEMUMachine, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 04/16] docs/devel/testing: add debug section to the QEMU iotests chapter, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 02/16] python: Reduce strictness of pylint's duplicate-code check,
Emanuele Giuseppe Esposito <=
- [PATCH v9 05/16] qemu-iotests: add option to attach gdbserver, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 06/16] qemu-iotests: delay QMP socket timers, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 07/16] qemu_iotests: insert gdbserver command line as wrapper for qemu binary, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 08/16] qemu-iotests: add gdbserver option to script tests too, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 09/16] docs/devel/testing: add -gdb option to the debugging section of QEMU iotests, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 10/16] qemu-iotests: extend the check script to prepare supporting valgrind for python tests, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 11/16] qemu-iotests: extend QMP socket timeout when using valgrind, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 12/16] qemu-iotests: allow valgrind to read/delete the generated log file, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 13/16] qemu-iotests: insert valgrind command line as wrapper for qemu binary, Emanuele Giuseppe Esposito, 2021/08/09
- [PATCH v9 14/16] docs/devel/testing: add -valgrind option to the debug section of QEMU iotests, Emanuele Giuseppe Esposito, 2021/08/09