Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host

[Igor Mammedov]

On Thu, 5 Aug 2021 18:13:21 -0400
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Thu, Aug 05, 2021 at 07:42:35PM +0530, Ani Sinha wrote:
> > Also to be noted that there is a stub for acpi_get_i386_pci_host() which
> > simply returns NULL. This activates when CONFIG_PC is disabled. It is this
> > stub that gets called for mips and hence the check for non-null host is
> > needed in acpi_set_pci_info() function.
> >   
> 
> Frankly this is generating more discussion that it's worth imho.
> IMHO these tweaks will bring little benefit.
> Igor do you feel differently?
replacing 'ifs' with assert is a bit cleaner, but if we are cleaning
it up we should clean up it properly without leaving unnecessary
code around.
That's why I suggested to separate x86 specific parts from piix4.
Philippe (CCed) even have reported issues ACPI parts were
causing on MIPS machines, so if someone is willing to untangle
the mess it might be worth the shot.