[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host |
|
Date: |
Thu, 5 Aug 2021 18:13:21 -0400 |
On Thu, Aug 05, 2021 at 07:42:35PM +0530, Ani Sinha wrote:
> Also to be noted that there is a stub for acpi_get_i386_pci_host() which
> simply returns NULL. This activates when CONFIG_PC is disabled. It is this
> stub that gets called for mips and hence the check for non-null host is
> needed in acpi_set_pci_info() function.
>
Frankly this is generating more discussion that it's worth imho.
IMHO these tweaks will bring little benefit.
Igor do you feel differently?
--
MST
- Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host, Ani Sinha, 2021/08/03
- Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host, Igor Mammedov, 2021/08/05
- Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host, Ani Sinha, 2021/08/05
- Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host, Igor Mammedov, 2021/08/06
- Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host, Ani Sinha, 2021/08/06
- Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host, Philippe Mathieu-Daudé, 2021/08/06
- Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host, Philippe Mathieu-Daudé, 2021/08/06
- Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host, Ani Sinha, 2021/08/09
- Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host, Ani Sinha, 2021/08/11