On Tue, Aug 03, 2021 at 01:34:32PM -0400, John Snow wrote:
> Got it. I was *just* about to send a refreshed version of this patchset
> because I found a new bug while on my way to making a sync compatibility
> shim for iotests -- Do you have more feedback cooking, or should I hit the
> send button?
I spotted another typo while browsing the web page (disconnect() "If
there were was an exception"), but I'm fine if you re-send, and I'll
Thanks for spotting that. Your proofreading ability is admired and appreciated :)
resume looking at the series on the updated v3. For 1-6, you can add:
Reviewed-by: Eric Blake <eblake@redhat.com>
although my python is weak enough that you may want another set of
eyes as well.
Thanks! Review on overall design, documentation, layout, organization and presentation is plenty helpful even if you aren't necessarily eagle-eyed on minutiae of Python. (Maybe especially if?)
I've written quite a few tests and have used this library to run our entire iotests suite, plus Niteesh has been banging the bits pretty hard while working on aqmp-shell, so I am not too fearful of mechanical errors.