Re: [PATCH v2 02/24] python/aqmp: add error classes

[John Snow]

Got it. I was *just* about to send a refreshed version of this patchset because I found a new bug while on my way to making a sync compatibility shim for iotests -- Do you have more feedback cooking, or should I hit the send button?

--js

On Tue, Aug 3, 2021 at 12:02 PM Eric Blake <eblake@redhat.com> wrote:

On Fri, Jul 16, 2021 at 08:32:31PM -0400, John Snow wrote:
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  python/qemu/aqmp/__init__.py |  4 +++
>  python/qemu/aqmp/error.py    | 50 ++++++++++++++++++++++++++++++++++++
>  2 files changed, 54 insertions(+)
>  create mode 100644 python/qemu/aqmp/error.py

> +++ b/python/qemu/aqmp/error.py
> @@ -0,0 +1,50 @@

> +
> +class ProtocolError(AQMPError):
> +    """
> +    Abstract error class for protocol failures.
> +
> +    Semantically, these errors are generally the fault of either the
> +    protocol server or as a result of a bug in this this library.

duplicate 'this'

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org