qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] doc: Remove trailing spaces


From: Axel Heider
Subject: Re: [PATCH 2/2] doc: Remove trailing spaces
Date: Tue, 3 Aug 2021 17:24:27 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

Peter,

Also, did you check that the docs still build without warnings
from a range of Sphinx versions and that the rendered HTML still
looks the same ? These trailing spaces were largely added deliberately
in commit 09ce5f2d6bd6739144, with the comment
   * rST does not like definition list entries with no actual
     definition, but it is possible to work around this by putting a
     single escaped literal space as the definition line.

so we should be careful not to delete them again unless we've
confirmed that we definitely don't re-introduce the issue that
we put them in to avoid...


Then please drop the patch 2/2 for now and just keep 1/2. I will run
more tests about this and see if I can find a way to avoid the need
for having traling spaces in the file. They are a bit dangerous as
most editors are set up to remove them, whch creates annoying changes
all the time then.

Axel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]