Re: [PATCH 2/2] doc: Remove trailing spaces

[Peter Maydell]

On Tue, 3 Aug 2021 at 15:14, Axel Heider <axelheider@gmx.de> wrote:
>
> Signed-off-by: Axel Heider <axelheider@gmx.de>
> ---
>   qemu-options.hx | 30 +++++++++++++++---------------
>   1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index e3f256fa72..ed91246114 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -244,15 +244,15 @@ DEF("numa", HAS_ARG, QEMU_OPTION_numa,
>       QEMU_ARCH_ALL)
>   SRST
>   ``-numa 
> node[,mem=size][,cpus=firstcpu[-lastcpu]][,nodeid=node][,initiator=initiator]``
> -  \
> +  \

Something seems to have gone wrong in sending your patch here --
the commit message claims it's deleting trailing spaces but the
patch itself doesn't do that. Something in the email path deleted
trailing spaces in the patch (I suspect the issue is the 'format=flowed'
in your email).

Also, did you check that the docs still build without warnings
from a range of Sphinx versions and that the rendered HTML still
looks the same ? These trailing spaces were largely added deliberately
in commit 09ce5f2d6bd6739144, with the comment
  * rST does not like definition list entries with no actual
    definition, but it is possible to work around this by putting a
    single escaped literal space as the definition line.

so we should be careful not to delete them again unless we've
confirmed that we definitely don't re-introduce the issue that
we put them in to avoid...

thanks
-- PMM