[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 8/8] virtio-gpu: Handle resource blob commands
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [PATCH v2 8/8] virtio-gpu: Handle resource blob commands |
|
Date: |
Fri, 30 Jul 2021 12:04:56 +0200 |
Hi,
> + region = g_new0(MemoryRegion, 1);
> + memory_region_init_ram_device_ptr(region, OBJECT(g), NULL, size, data);
> + memory_region_add_subregion(&g->parent_obj.hostmem, mblob.offset,
> region);
> + memory_region_set_enabled(region, true);
You leak the region instead of properly cleaning it up on unmap.
take care,
Gerd
- [PATCH v2 4/8] virtio-gpu: Shared memory capability, (continued)
- [PATCH v2 4/8] virtio-gpu: Shared memory capability, Antonio Caggiano, 2021/07/28
- [PATCH v2 5/8] virtio-gpu: Resource UUID, Antonio Caggiano, 2021/07/28
- [PATCH v2 2/8] virtio-gpu: hostmem [wip], Antonio Caggiano, 2021/07/28
- [PATCH v2 6/8] virtio-gpu: Support Venus capset, Antonio Caggiano, 2021/07/28
- [PATCH v2 8/8] virtio-gpu: Handle resource blob commands, Antonio Caggiano, 2021/07/28
- Re: [PATCH v2 8/8] virtio-gpu: Handle resource blob commands,
Gerd Hoffmann <=
- [PATCH v2 7/8] virtio-gpu: Initialize Venus, Antonio Caggiano, 2021/07/28