Re: [PATCH v2 4/8] virtio-gpu: Shared memory capability

[Gerd Hoffmann]

> -        virtio_pci_add_shm_cap(vpci_dev, 4, 0, g->conf.hostmem, 0);
> +        virtio_pci_add_shm_cap(vpci_dev, 4, 0, g->conf.hostmem, 
> VIRTIO_GPU_SHM_ID_HOST_VISIBLE);

Squash that into patch #2

> --- a/include/standard-headers/linux/virtio_pci.h
> +++ b/include/standard-headers/linux/virtio_pci.h
> @@ -172,13 +172,6 @@ struct virtio_pci_cfg_cap {
>       uint8_t pci_cfg_data[4]; /* Data for BAR access. */
>  };
>  
> -struct virtio_pci_shm_cap {
> -     struct virtio_pci_cap cap;
> -     uint32_t offset_hi;             /* Most sig 32 bits of offset */
> -     uint32_t length_hi;             /* Most sig 32 bits of length */
> -     uint8_t  id;                    /* To distinguish shm chunks */
> -};
> -

Hmm?  I doubt this is correct ...

take care,
  Gerd