[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/9] gitlab-ci: Fix 'when:' condition in acceptance_test_job_templ
From: |
Thomas Huth |
Subject: |
[PULL 2/9] gitlab-ci: Fix 'when:' condition in acceptance_test_job_template |
Date: |
Thu, 29 Jul 2021 10:22:04 +0200 |
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Jobs depending on another should not use the 'when: always'
condition, because if a dependency failed we should not keep
running jobs depending on it. The correct condition is
'when: on_success'.
Fixes: f56bf4caf71 ("gitlab: Run Avocado tests manually (except mainstream CI)")
Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20210727142431.1672530-3-philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
.gitlab-ci.d/buildtest-template.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.gitlab-ci.d/buildtest-template.yml
b/.gitlab-ci.d/buildtest-template.yml
index 3e3e19d96b..fcbcc4e627 100644
--- a/.gitlab-ci.d/buildtest-template.yml
+++ b/.gitlab-ci.d/buildtest-template.yml
@@ -73,9 +73,9 @@
# in its namespace setting or via git-push option, see documentation
# in /.gitlab-ci.yml of this repository).
- if: '$CI_PROJECT_NAMESPACE == "qemu-project"'
- when: always
+ when: on_success
- if: '$QEMU_CI_AVOCADO_TESTING'
- when: always
+ when: on_success
# Otherwise, set to manual (the jobs are created but not run).
- when: manual
allow_failure: true
--
2.27.0
- [PULL 0/9] Gitlab-CI improvements and some other fixes, Thomas Huth, 2021/07/29
- [PULL 1/9] docs: Document GitLab custom CI/CD variables, Thomas Huth, 2021/07/29
- [PULL 2/9] gitlab-ci: Fix 'when:' condition in acceptance_test_job_template,
Thomas Huth <=
- [PULL 3/9] gitlab-ci: Fix 'when:' condition in EDK2 jobs, Thomas Huth, 2021/07/29
- [PULL 4/9] gitlab-ci: Fix 'when:' condition in OpenSBI jobs, Thomas Huth, 2021/07/29
- [PULL 5/9] gitlab-ci.d/buildtest: Disable iotests 197 and 215, Thomas Huth, 2021/07/29
- [PULL 6/9] gitlab-ci.d/buildtest: Mark the aarch64 and ppc64-s390x CFI jobs as manual, Thomas Huth, 2021/07/29
- [PULL 7/9] gitlab-ci.d/custom-runners: Improve rules for the staging branch, Thomas Huth, 2021/07/29
- [PULL 8/9] tests: Fix migration-test build failure for sparc, Thomas Huth, 2021/07/29
- [PULL 9/9] configure script fix for Haiku, Thomas Huth, 2021/07/29
- Re: [PULL 0/9] Gitlab-CI improvements and some other fixes, Peter Maydell, 2021/07/29