[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH-for-6.1 v5 2/4] gitlab-ci: Fix 'when:' condition in acceptance_te
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH-for-6.1 v5 2/4] gitlab-ci: Fix 'when:' condition in acceptance_test_job_template |
Date: |
Tue, 27 Jul 2021 16:24:29 +0200 |
Jobs depending on another should not use the 'when: always'
condition, because if a dependency failed we should not keep
running jobs depending on it. The correct condition is
'when: on_success'.
Fixes: f56bf4caf71 ("gitlab: Run Avocado tests manually (except mainstream CI)")
Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
.gitlab-ci.d/buildtest-template.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.gitlab-ci.d/buildtest-template.yml
b/.gitlab-ci.d/buildtest-template.yml
index 3e3e19d96bd..fcbcc4e627a 100644
--- a/.gitlab-ci.d/buildtest-template.yml
+++ b/.gitlab-ci.d/buildtest-template.yml
@@ -73,9 +73,9 @@
# in its namespace setting or via git-push option, see documentation
# in /.gitlab-ci.yml of this repository).
- if: '$CI_PROJECT_NAMESPACE == "qemu-project"'
- when: always
+ when: on_success
- if: '$QEMU_CI_AVOCADO_TESTING'
- when: always
+ when: on_success
# Otherwise, set to manual (the jobs are created but not run).
- when: manual
allow_failure: true
--
2.31.1
- [PATCH-for-6.1 v5 0/4] gitlab-ci: Document custom CI/CD variables, fix 'when:' conditions, Philippe Mathieu-Daudé, 2021/07/27
- [PATCH-for-6.1 v5 2/4] gitlab-ci: Fix 'when:' condition in acceptance_test_job_template,
Philippe Mathieu-Daudé <=
- [PATCH-for-6.1 v5 1/4] docs: Document GitLab custom CI/CD variables, Philippe Mathieu-Daudé, 2021/07/27
- [PATCH-for-6.1 v5 3/4] gitlab-ci: Fix 'when:' condition in EDK2 jobs, Philippe Mathieu-Daudé, 2021/07/27
- [PATCH-for-6.1 v5 4/4] gitlab-ci: Fix 'when:' condition in OpenSBI jobs, Philippe Mathieu-Daudé, 2021/07/27
- Re: [PATCH-for-6.1 v5 0/4] gitlab-ci: Document custom CI/CD variables, fix 'when:' conditions, Thomas Huth, 2021/07/27