Re: [PATCH RFC 03/19] vfio-user: define VFIO Proxy and communication functions

[Stefan Hajnoczi]

On Wed, Jul 28, 2021 at 06:08:26PM +0000, John Johnson wrote:
> 
> 
> > On Jul 27, 2021, at 9:34 AM, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > 
> > On Sun, Jul 18, 2021 at 11:27:42PM -0700, Elena Ufimtseva wrote:
> >> From: John G Johnson <john.g.johnson@oracle.com>
> >> 
> >> Add user.c and user.h files for vfio-user with the basic
> >> send and receive functions.
> >> 
> >> Signed-off-by: John G Johnson <john.g.johnson@oracle.com>
> >> Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> >> Signed-off-by: Jagannathan Raman <jag.raman@oracle.com>
> >> ---
> >> hw/vfio/user.h                | 120 ++++++++++++++
> >> include/hw/vfio/vfio-common.h |   2 +
> >> hw/vfio/user.c                | 286 ++++++++++++++++++++++++++++++++++
> >> MAINTAINERS                   |   4 +
> >> hw/vfio/meson.build           |   1 +
> >> 5 files changed, 413 insertions(+)
> >> create mode 100644 hw/vfio/user.h
> >> create mode 100644 hw/vfio/user.c
> > 
> > The multi-threading, coroutine, and blocking I/O requirements of
> > vfio_user_recv() and vfio_user_send_reply() are unclear to me. Please
> > document them so it's clear what environment they can be called from. I
> > guess they are not called from coroutines and proxy->ioc is a blocking
> > IOChannel?
> > 
> 
>       Yes to both, moreover, a block comment above vfio_user_recv() would
> be useful.  The call to setup vfio_user_recv() as the socket handler isn’t
> in this patch, do you want the series re-org’d?

That would help with review, thanks!

Stefan

signature.asc
Description: PGP signature