Re: [PATCH 2/2] libvhost-user: fix -Werror=format= warnings with __u64 fields

[Paolo Bonzini]

On 05/05/21 17:38, Stefan Hajnoczi wrote:
> On Wed, May 05, 2021 at 07:13:13PM +0400, marcandre.lureau@redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > ../subprojects/libvhost-user/libvhost-user.c:1070:12: error: format ‘%lx’ 
> > expects argument of type ‘long unsigned int’, but argument 3 has type ‘__u64’ 
> > {aka ‘long long unsigned int’} [-Werror=format=]
> >   1070 |     DPRINT("    desc_user_addr:   0x%016" PRIx64 "\n", 
> > vra->desc_user_addr);
> >        |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~              
> > ~~~~~~~~~~~~~~~~~~~
> >        |                                                           |
> >        |                                                           __u64 {aka 
> > long long unsigned int}
> >
> > Rather than using %llx, which may fail if __u64 is declared differently
> > elsewhere, let's just cast the values. Feel free to propose a better solution!
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> >   subprojects/libvhost-user/libvhost-user.c | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)
>
> Looks good to me:
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Queued both, thanks.

Paolo