[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.2 34/43] target/mips: Use cpu_*_data_ra for msa load/st
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH for-6.2 34/43] target/mips: Use cpu_*_data_ra for msa load/store |
|
Date: |
Thu, 29 Jul 2021 09:38:33 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 7/29/21 2:46 AM, Richard Henderson wrote:
> We should not have been using the helper_ret_* set of
> functions, as they are supposed to be private to tcg.
> Nor should we have been using the plain cpu_*_data set
> of functions, as they do not handle unwinding properly.
>
> Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/mips/tcg/msa_helper.c | 420 +++++++++++------------------------
> 1 file changed, 135 insertions(+), 285 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- Re: [PATCH for-6.2 27/43] target/arm: Use MO_128 for 16 byte atomics, (continued)
- [PATCH for-6.2 30/43] target/s390x: Use MO_128 for 16 byte atomics, Richard Henderson, 2021/07/28
- [PATCH for-6.2 31/43] target/hexagon: Implement cpu_mmu_index, Richard Henderson, 2021/07/28
- [PATCH for-6.2 33/43] accel/tcg: Move cpu_atomic decls to exec/cpu_ldst.h, Richard Henderson, 2021/07/28
- [PATCH for-6.2 32/43] accel/tcg: Add cpu_{ld,st}*_mmu interfaces, Richard Henderson, 2021/07/28
- [PATCH for-6.2 34/43] target/mips: Use cpu_*_data_ra for msa load/store, Richard Henderson, 2021/07/28
- Re: [PATCH for-6.2 34/43] target/mips: Use cpu_*_data_ra for msa load/store,
Philippe Mathieu-Daudé <=
- [PATCH for-6.2 36/43] target/s390x: Use cpu_*_mmu instead of helper_*_mmu, Richard Henderson, 2021/07/28
- [PATCH for-6.2 38/43] target/arm: Use cpu_*_mmu instead of helper_*_mmu, Richard Henderson, 2021/07/28
- [PATCH for-6.2 39/43] tcg: Move helper_*_mmu decls to tcg/tcg-ldst.h, Richard Henderson, 2021/07/28
- [PATCH for-6.2 35/43] target/mips: Use 8-byte memory ops for msa load/store, Richard Henderson, 2021/07/28
- [PATCH for-6.2 37/43] target/sparc: Use cpu_*_mmu instead of helper_*_mmu, Richard Henderson, 2021/07/28
- [PATCH for-6.2 40/43] linux-user/alpha: Remove TARGET_ALIGNED_ONLY, Richard Henderson, 2021/07/28
- [PATCH for-6.2 41/43] tcg: Add helper_unaligned_mmu for user-only sigbus, Richard Henderson, 2021/07/28