[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 15/22] target/loongarch: Add floating point conversion ins
|
From: |
Song Gao |
|
Subject: |
Re: [PATCH v2 15/22] target/loongarch: Add floating point conversion instruction translation |
|
Date: |
Tue, 27 Jul 2021 15:57:40 +0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux mips64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
Hi Richard.
On 07/23/2021 02:16 PM, Richard Henderson wrote:
> On 7/20/21 11:53 PM, Song Gao wrote:
>> +uint64_t helper_fp_tintrm_l_d(CPULoongArchState *env, uint64_t src)
>> +{
>> + uint64_t dest;
>> +
>> + set_float_rounding_mode(float_round_down, &env->active_fpu.fp_status);
>> + dest = float64_to_int64(src, &env->active_fpu.fp_status);
>> + restore_rounding_mode(env);
>
> Better off to save the current rounding mode with get_float_rounding_mode,
> and restore it afterward.
>
> See 63d06e90e65d5f119039044e986a81007954a466.
>
OK.
>
> r~
Thanks
Song Gao.
- [PATCH v2 12/22] target/loongarch: Add fixed point extra instruction translation, (continued)
[PATCH v2 13/22] target/loongarch: Add floating point arithmetic instruction translation, Song Gao, 2021/07/21
[PATCH v2 15/22] target/loongarch: Add floating point conversion instruction translation, Song Gao, 2021/07/21
[PATCH v2 14/22] target/loongarch: Add floating point comparison instruction translation, Song Gao, 2021/07/21
[PATCH v2 16/22] target/loongarch: Add floating point move instruction translation, Song Gao, 2021/07/21
[PATCH v2 18/22] target/loongarch: Add branch instruction translation, Song Gao, 2021/07/21
[PATCH v2 17/22] target/loongarch: Add floating point load/store instruction translation, Song Gao, 2021/07/21