[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 7/9] cpus: Introduce qemu_mutex_unlock_iothread_prepare()
From: |
Peter Xu |
Subject: |
[PATCH v2 7/9] cpus: Introduce qemu_mutex_unlock_iothread_prepare() |
Date: |
Fri, 23 Jul 2021 15:34:42 -0400 |
The prepare function before unlocking BQL. There're only three places that can
release the BQL: unlock(), cond_wait() or cond_timedwait().
Signed-off-by: Peter Xu <peterx@redhat.com>
---
softmmu/cpus.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/softmmu/cpus.c b/softmmu/cpus.c
index 9131f77f87..6085f8edbe 100644
--- a/softmmu/cpus.c
+++ b/softmmu/cpus.c
@@ -66,6 +66,10 @@
static QemuMutex qemu_global_mutex;
+static void qemu_mutex_unlock_iothread_prepare(void)
+{
+}
+
bool cpu_is_stopped(CPUState *cpu)
{
return cpu->stopped || !runstate_is_running();
@@ -523,16 +527,19 @@ void qemu_mutex_unlock_iothread(void)
{
g_assert(qemu_mutex_iothread_locked());
iothread_locked = false;
+ qemu_mutex_unlock_iothread_prepare();
qemu_mutex_unlock(&qemu_global_mutex);
}
void qemu_cond_wait_iothread(QemuCond *cond)
{
+ qemu_mutex_unlock_iothread_prepare();
qemu_cond_wait(cond, &qemu_global_mutex);
}
void qemu_cond_timedwait_iothread(QemuCond *cond, int ms)
{
+ qemu_mutex_unlock_iothread_prepare();
qemu_cond_timedwait(cond, &qemu_global_mutex, ms);
}
--
2.31.1
- Re: [PATCH v2 4/9] memory: Don't do topology update in memory finalize(), (continued)
[PATCH v2 5/9] cpus: Use qemu_cond_wait_iothread() where proper, Peter Xu, 2021/07/23
[PATCH v2 8/9] memory: Assert on no ongoing memory transaction before release BQL, Peter Xu, 2021/07/23
[PATCH v2 9/9] memory: Delay the transaction pop() until commit completed, Peter Xu, 2021/07/23
[PATCH v2 6/9] cpus: Remove the mutex parameter from do_run_on_cpu(), Peter Xu, 2021/07/23
[PATCH v2 7/9] cpus: Introduce qemu_mutex_unlock_iothread_prepare(),
Peter Xu <=
Re: [PATCH v2 0/9] memory: Sanity checks memory transaction when releasing BQL, Peter Xu, 2021/07/23
Re: [PATCH v2 0/9] memory: Sanity checks memory transaction when releasing BQL, David Hildenbrand, 2021/07/27