Re: [PATCH v2 6/9] cpus: Remove the mutex parameter from do_run_on

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 6/9] cpus: Remove the mutex parameter from do_run_on_cpu()

From:	David Hildenbrand
Subject:	Re: [PATCH v2 6/9] cpus: Remove the mutex parameter from do_run_on_cpu()
Date:	Tue, 27 Jul 2021 14:50:08 +0200
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 23.07.21 21:34, Peter Xu wrote:

We must use the BQL for do_run_on_cpu() without much choice, it means the
parameter is helpless.  Remove it.  Meanwhile use the newly introduced


s/helpless/useless/ ?

Reviewed-by: David Hildenbrand <david@redhat.com>

--
Thanks,

David / dhildenb

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v2 4/9] memory: Don't do topology update in memory finalize(), (continued)
- [PATCH v2 5/9] cpus: Use qemu_cond_wait_iothread() where proper, Peter Xu, 2021/07/23
  - Re: [PATCH v2 5/9] cpus: Use qemu_cond_wait_iothread() where proper, David Hildenbrand, 2021/07/27
- [PATCH v2 8/9] memory: Assert on no ongoing memory transaction before release BQL, Peter Xu, 2021/07/23
  - Re: [PATCH v2 8/9] memory: Assert on no ongoing memory transaction before release BQL, David Hildenbrand, 2021/07/27
- [PATCH v2 9/9] memory: Delay the transaction pop() until commit completed, Peter Xu, 2021/07/23
  - Re: [PATCH v2 9/9] memory: Delay the transaction pop() until commit completed, David Hildenbrand, 2021/07/27
- [PATCH v2 6/9] cpus: Remove the mutex parameter from do_run_on_cpu(), Peter Xu, 2021/07/23
  - Re: [PATCH v2 6/9] cpus: Remove the mutex parameter from do_run_on_cpu(), David Hildenbrand <=
- [PATCH v2 7/9] cpus: Introduce qemu_mutex_unlock_iothread_prepare(), Peter Xu, 2021/07/23
  - Re: [PATCH v2 7/9] cpus: Introduce qemu_mutex_unlock_iothread_prepare(), David Hildenbrand, 2021/07/27
    - Re: [PATCH v2 7/9] cpus: Introduce qemu_mutex_unlock_iothread_prepare(), Peter Xu, 2021/07/27
    - Re: [PATCH v2 7/9] cpus: Introduce qemu_mutex_unlock_iothread_prepare(), David Hildenbrand, 2021/07/28
- Re: [PATCH v2 0/9] memory: Sanity checks memory transaction when releasing BQL, Peter Xu, 2021/07/23
- Re: [PATCH v2 0/9] memory: Sanity checks memory transaction when releasing BQL, David Hildenbrand, 2021/07/27
  - Re: [PATCH v2 0/9] memory: Sanity checks memory transaction when releasing BQL, Peter Xu, 2021/07/27

Prev by Date: Re: [PATCH 0/3] docs: convert qapi-code-gen.txt to qapi-code-gen.rst
Next by Date: Re: [PATCH v5 05/10] ACPI ERST: support for ACPI ERST feature
Previous by thread: [PATCH v2 6/9] cpus: Remove the mutex parameter from do_run_on_cpu()
Next by thread: [PATCH v2 7/9] cpus: Introduce qemu_mutex_unlock_iothread_prepare()
Index(es):
- Date
- Thread