[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 13/17] hw/pci-host/Kconfig: Add missing dependency MV64361 -> I825
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 13/17] hw/pci-host/Kconfig: Add missing dependency MV64361 -> I8259 |
Date: |
Tue, 20 Jul 2021 17:41:37 +0200 |
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Looking at the MV64340 model source, there is a dependency on the
8259 interrupt controller:
523 case MV64340_PCI_1_INTERRUPT_ACKNOWLEDGE_VIRTUAL_REG:
524 /* FIXME: Should this be sent via the PCI bus somehow? */
525 if (s->gpp_int_level && (s->gpp_value & BIT(31))) {
526 ret = pic_read_irq(isa_pic);
527 }
528 break;
Add it to Kconfig to avoid the following build failure:
/usr/bin/ld: libcommon.fa.p/hw_pci-host_mv64361.c.o: in function
`mv64361_read':
hw/pci-host/mv64361.c:526: undefined reference to `isa_pic'
/usr/bin/ld: hw/pci-host/mv64361.c:526: undefined reference to `pic_read_irq'
Fixes: dcdf98a9015 ("hw/pci-host: Add emulation of Marvell MV64361 PPC system
controller")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Message-Id: <20210515173716.358295-10-philmd@redhat.com>
---
hw/pci-host/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig
index 84494400b86..2b5f7d58cc5 100644
--- a/hw/pci-host/Kconfig
+++ b/hw/pci-host/Kconfig
@@ -76,3 +76,4 @@ config SH_PCI
config MV64361
bool
select PCI
+ select I8259
--
2.31.1
- [PULL 02/17] hw/mips: Express dependencies of the Boston machine with Kconfig, (continued)
- [PULL 02/17] hw/mips: Express dependencies of the Boston machine with Kconfig, Philippe Mathieu-Daudé, 2021/07/20
- [PULL 03/17] hw/acpi: Do not restrict ACPI core routines to x86 architecture, Philippe Mathieu-Daudé, 2021/07/20
- [PULL 04/17] hw/acpi/Kconfig: Add missing Kconfig dependencies (build error), Philippe Mathieu-Daudé, 2021/07/20
- [PULL 05/17] hw/i386/Kconfig: Add missing Kconfig dependency (runtime error), Philippe Mathieu-Daudé, 2021/07/20
- [PULL 06/17] hw/ide/Kconfig: Add missing dependency PCI -> IDE_QDEV, Philippe Mathieu-Daudé, 2021/07/20
- [PULL 07/17] hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS, Philippe Mathieu-Daudé, 2021/07/20
- [PULL 08/17] hw/arm/Kconfig: Remove unused DS1338 symbol from i.MX25 PDK Board, Philippe Mathieu-Daudé, 2021/07/20
- [PULL 09/17] hw/arm/Kconfig: Add missing SDHCI symbol to FSL_IMX25, Philippe Mathieu-Daudé, 2021/07/20
- [PULL 11/17] hw/riscv/Kconfig: Restrict NUMA to Virt & Spike machines, Philippe Mathieu-Daudé, 2021/07/20
- [PULL 12/17] hw/ppc/Kconfig: Add missing dependency E500 -> DS1338 RTC, Philippe Mathieu-Daudé, 2021/07/20
- [PULL 13/17] hw/pci-host/Kconfig: Add missing dependency MV64361 -> I8259,
Philippe Mathieu-Daudé <=
- [PULL 14/17] hw/isa/vt82c686: Add missing Kconfig dependencies (build error), Philippe Mathieu-Daudé, 2021/07/20
- [PULL 15/17] hw/isa/vt82c686: Add missing Kconfig dependency (runtime error), Philippe Mathieu-Daudé, 2021/07/20
- [PULL 16/17] hw/ppc/Kconfig: Add dependency PEGASOS2 -> ATI_VGA, Philippe Mathieu-Daudé, 2021/07/20
- [PULL 17/17] hw/tricore: fix inclusion of tricore_testboard, Philippe Mathieu-Daudé, 2021/07/20
- [PULL 10/17] hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL, Philippe Mathieu-Daudé, 2021/07/20
- Re: [PULL 00/17] Kconfig patches for 2021-07-20, Peter Maydell, 2021/07/21