[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/17] hw/ppc/Kconfig: Add missing dependency E500 -> DS1338 RTC
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 12/17] hw/ppc/Kconfig: Add missing dependency E500 -> DS1338 RTC |
Date: |
Tue, 20 Jul 2021 17:41:36 +0200 |
Commit 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate
RTC with it") added a global dependency on the DS1338 model, instead
of a machine one (via Kconfig). This gives trouble when building
standalone machines not exposing I2C bus:
The following clauses were found for DS1338
CONFIG_DS1338=y
config DS1338 depends on I2C
Fix by selecting the DS1338 symbol in the single machine requiring
it, the E500.
Fixes: 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate RTC with
it")
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210513163858.3928976-9-philmd@redhat.com>
---
configs/devices/ppc-softmmu/default.mak | 1 -
hw/ppc/Kconfig | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/devices/ppc-softmmu/default.mak
b/configs/devices/ppc-softmmu/default.mak
index 4535993d8d5..658a454426e 100644
--- a/configs/devices/ppc-softmmu/default.mak
+++ b/configs/devices/ppc-softmmu/default.mak
@@ -1,7 +1,6 @@
# Default configuration for ppc-softmmu
# For embedded PPCs:
-CONFIG_DS1338=y
CONFIG_E500=y
CONFIG_PPC405=y
CONFIG_PPC440=y
diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
index 322a7eb031e..85b9c93f02e 100644
--- a/hw/ppc/Kconfig
+++ b/hw/ppc/Kconfig
@@ -130,6 +130,7 @@ config E500
select SERIAL
select MPC_I2C
select FDT_PPC
+ select DS1338
config VIRTEX
bool
--
2.31.1
- [PULL 01/17] hw/mips: Add dependency MIPS_CPS -> MIPS_ITU, (continued)
- [PULL 01/17] hw/mips: Add dependency MIPS_CPS -> MIPS_ITU, Philippe Mathieu-Daudé, 2021/07/20
- [PULL 02/17] hw/mips: Express dependencies of the Boston machine with Kconfig, Philippe Mathieu-Daudé, 2021/07/20
- [PULL 03/17] hw/acpi: Do not restrict ACPI core routines to x86 architecture, Philippe Mathieu-Daudé, 2021/07/20
- [PULL 04/17] hw/acpi/Kconfig: Add missing Kconfig dependencies (build error), Philippe Mathieu-Daudé, 2021/07/20
- [PULL 05/17] hw/i386/Kconfig: Add missing Kconfig dependency (runtime error), Philippe Mathieu-Daudé, 2021/07/20
- [PULL 06/17] hw/ide/Kconfig: Add missing dependency PCI -> IDE_QDEV, Philippe Mathieu-Daudé, 2021/07/20
- [PULL 07/17] hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS, Philippe Mathieu-Daudé, 2021/07/20
- [PULL 08/17] hw/arm/Kconfig: Remove unused DS1338 symbol from i.MX25 PDK Board, Philippe Mathieu-Daudé, 2021/07/20
- [PULL 09/17] hw/arm/Kconfig: Add missing SDHCI symbol to FSL_IMX25, Philippe Mathieu-Daudé, 2021/07/20
- [PULL 11/17] hw/riscv/Kconfig: Restrict NUMA to Virt & Spike machines, Philippe Mathieu-Daudé, 2021/07/20
- [PULL 12/17] hw/ppc/Kconfig: Add missing dependency E500 -> DS1338 RTC,
Philippe Mathieu-Daudé <=
- [PULL 13/17] hw/pci-host/Kconfig: Add missing dependency MV64361 -> I8259, Philippe Mathieu-Daudé, 2021/07/20
- [PULL 14/17] hw/isa/vt82c686: Add missing Kconfig dependencies (build error), Philippe Mathieu-Daudé, 2021/07/20
- [PULL 15/17] hw/isa/vt82c686: Add missing Kconfig dependency (runtime error), Philippe Mathieu-Daudé, 2021/07/20
- [PULL 16/17] hw/ppc/Kconfig: Add dependency PEGASOS2 -> ATI_VGA, Philippe Mathieu-Daudé, 2021/07/20
- [PULL 17/17] hw/tricore: fix inclusion of tricore_testboard, Philippe Mathieu-Daudé, 2021/07/20
- [PULL 10/17] hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL, Philippe Mathieu-Daudé, 2021/07/20
- Re: [PULL 00/17] Kconfig patches for 2021-07-20, Peter Maydell, 2021/07/21