[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 01/11] qemu/atomic: Use macros for CONFIG_ATOMIC64
From: |
Richard Henderson |
Subject: |
[PATCH v2 01/11] qemu/atomic: Use macros for CONFIG_ATOMIC64 |
Date: |
Fri, 16 Jul 2021 18:41:11 -0700 |
Clang warnings about questionable atomic usage get localized
to the inline function in atomic.h. By using a macro, we get
the full traceback to the original use that caused the warning.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
include/qemu/atomic.h | 25 +++++--------------------
1 file changed, 5 insertions(+), 20 deletions(-)
diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h
index 3ccf84fd46..99d6030095 100644
--- a/include/qemu/atomic.h
+++ b/include/qemu/atomic.h
@@ -457,26 +457,11 @@
/* Abstractions to access atomically (i.e. "once") i64/u64 variables */
#ifdef CONFIG_ATOMIC64
-static inline int64_t qatomic_read_i64(const int64_t *ptr)
-{
- /* use __nocheck because sizeof(void *) might be < sizeof(u64) */
- return qatomic_read__nocheck(ptr);
-}
-
-static inline uint64_t qatomic_read_u64(const uint64_t *ptr)
-{
- return qatomic_read__nocheck(ptr);
-}
-
-static inline void qatomic_set_i64(int64_t *ptr, int64_t val)
-{
- qatomic_set__nocheck(ptr, val);
-}
-
-static inline void qatomic_set_u64(uint64_t *ptr, uint64_t val)
-{
- qatomic_set__nocheck(ptr, val);
-}
+/* Use __nocheck because sizeof(void *) might be < sizeof(u64) */
+#define qatomic_read_i64 qatomic_read__nocheck
+#define qatomic_read_u64 qatomic_read__nocheck
+#define qatomic_set_i64 qatomic_set__nocheck
+#define qatomic_set_u64 qatomic_set__nocheck
static inline void qatomic64_init(void)
{
--
2.25.1
- [PATCH v2 00/11] Atomic cleanup + clang-12 build fix, Richard Henderson, 2021/07/16
- [PATCH v2 01/11] qemu/atomic: Use macros for CONFIG_ATOMIC64,
Richard Henderson <=
- [PATCH v2 02/11] qemu/atomic: Simplify typeof_strip_qual, Richard Henderson, 2021/07/16
- [PATCH v2 03/11] qemu/atomic: Remove pre-C11 atomic fallbacks, Richard Henderson, 2021/07/16
- [PATCH v2 05/11] tcg: Rename helper_atomic_*_mmu and provide for user-only, Richard Henderson, 2021/07/16
- [PATCH v2 07/11] accel/tcg: Fold EXTRA_ARGS into atomic_template.h, Richard Henderson, 2021/07/16
- [PATCH v2 04/11] qemu/atomic: Add aligned_{int64,uint64}_t types, Richard Henderson, 2021/07/16
- [PATCH v2 06/11] accel/tcg: Standardize atomic helpers on softmmu api, Richard Henderson, 2021/07/16
- [PATCH v2 09/11] accel/tcg: Expand ATOMIC_MMU_LOOKUP_*, Richard Henderson, 2021/07/16