[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/17] target/riscv: Use gpr_{src,dst} for RVB
|
From: |
Alistair Francis |
|
Subject: |
Re: [PATCH 11/17] target/riscv: Use gpr_{src,dst} for RVB |
|
Date: |
Thu, 15 Jul 2021 14:52:54 +1000 |
On Fri, Jul 9, 2021 at 2:37 PM Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/insn_trans/trans_rvb.c.inc | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/target/riscv/insn_trans/trans_rvb.c.inc
> b/target/riscv/insn_trans/trans_rvb.c.inc
> index 9e81f6e3de..58921f3224 100644
> --- a/target/riscv/insn_trans/trans_rvb.c.inc
> +++ b/target/riscv/insn_trans/trans_rvb.c.inc
> @@ -423,16 +423,13 @@ static bool trans_slli_uw(DisasContext *ctx,
> arg_slli_uw *a)
> REQUIRE_64BIT(ctx);
> REQUIRE_EXT(ctx, RVB);
>
> - TCGv source1 = tcg_temp_new();
> - gen_get_gpr(source1, a->rs1);
> + TCGv dest = gpr_dst(ctx, a->rd);
> + TCGv src1 = gpr_src(ctx, a->rs1);
>
> if (a->shamt < 32) {
> - tcg_gen_deposit_z_tl(source1, source1, a->shamt, 32);
> + tcg_gen_deposit_z_tl(dest, src1, a->shamt, 32);
> } else {
> - tcg_gen_shli_tl(source1, source1, a->shamt);
> + tcg_gen_shli_tl(dest, src1, a->shamt);
> }
> -
> - gen_set_gpr(a->rd, source1);
> - tcg_temp_free(source1);
> return true;
> }
> --
> 2.25.1
>
>
- [PATCH 06/17] target/riscv: Use gpr_src in branches, (continued)
- [PATCH 06/17] target/riscv: Use gpr_src in branches, Richard Henderson, 2021/07/09
- [PATCH 16/17] target/riscv: Use gpr_{src,dst} for RVV, Richard Henderson, 2021/07/09
- [PATCH 07/17] target/riscv: Use gpr_{src,dst} for integer load/store, Richard Henderson, 2021/07/09
- [PATCH 08/17] target/riscv: Use gpr_{src, dst} for word shift operations, Richard Henderson, 2021/07/09
- [PATCH 09/17] target/riscv: Reorg csr instructions, Richard Henderson, 2021/07/09
- [PATCH 11/17] target/riscv: Use gpr_{src,dst} for RVB, Richard Henderson, 2021/07/09
- Re: [PATCH 11/17] target/riscv: Use gpr_{src,dst} for RVB,
Alistair Francis <=
- [PATCH 12/17] target/riscv: Use gpr_{src,dst} for RVF, Richard Henderson, 2021/07/09
- [PATCH 13/17] target/riscv: Use gpr_{src,dst} for RVD, Richard Henderson, 2021/07/09
- [PATCH 15/17] target/riscv: Use gen_arith for mulh and mulhu, Richard Henderson, 2021/07/09
- [PATCH 17/17] target/riscv: Remove gen_get_gpr, Richard Henderson, 2021/07/09
- Re: [PATCH 00/17] target/riscv: Use tcg_constant_*, LIU Zhiwei, 2021/07/15