[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/11] accel/tcg: Remove unused variable in cpu_exec
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 02/11] accel/tcg: Remove unused variable in cpu_exec |
Date: |
Tue, 13 Jul 2021 18:27:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 7/12/21 11:55 PM, Richard Henderson wrote:
> From clang-13:
> accel/tcg/cpu-exec.c:783:15: error: variable 'cc' set but not used \
> [-Werror,-Wunused-but-set-variable]
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> accel/tcg/cpu-exec.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
> index e22bcb99f7..a8d8cea586 100644
> --- a/accel/tcg/cpu-exec.c
> +++ b/accel/tcg/cpu-exec.c
> @@ -780,7 +780,6 @@ static inline void cpu_loop_exec_tb(CPUState *cpu,
> TranslationBlock *tb,
>
> int cpu_exec(CPUState *cpu)
> {
> - CPUClass *cc = CPU_GET_CLASS(cpu);
> int ret;
> SyncClocks sc = { 0 };
>
> @@ -819,14 +818,12 @@ int cpu_exec(CPUState *cpu)
> * so we only perform the workaround for clang.
> */
> cpu = current_cpu;
> - cc = CPU_GET_CLASS(cpu);
> #else
> /*
> * Non-buggy compilers preserve these locals; assert that
> * they have the correct value.
Maybe update comment to singular, otherwise:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> */
> g_assert(cpu == current_cpu);
> - g_assert(cc == CPU_GET_CLASS(cpu));
> #endif
>
> #ifndef CONFIG_SOFTMMU
>
[PATCH 04/11] net/checksum: Remove unused variable in net_checksum_add_iov, Richard Henderson, 2021/07/12
[PATCH 03/11] util/selfmap: Discard mapping on error, Richard Henderson, 2021/07/12
[PATCH 02/11] accel/tcg: Remove unused variable in cpu_exec, Richard Henderson, 2021/07/12
- Re: [PATCH 02/11] accel/tcg: Remove unused variable in cpu_exec,
Philippe Mathieu-Daudé <=
[PATCH 07/11] hw/pci-hist/pnv_phb4: Fix typo in pnv_phb4_ioda_write, Richard Henderson, 2021/07/12
[PATCH 05/11] hw/audio/adlib: Remove unused variable in adlib_callback, Richard Henderson, 2021/07/12
[PATCH 06/11] hw/ppc/spapr_events: Remove unused variable from check_exception, Richard Henderson, 2021/07/12
[PATCH 08/11] linux-user/syscall: Remove unused variable from execve, Richard Henderson, 2021/07/12
[PATCH 11/11] tcg/ppc: Ensure _CALL_SYSV is set for 32-bit ELF, Richard Henderson, 2021/07/12
[PATCH 09/11] tests/unit: Remove unused variable from test_io, Richard Henderson, 2021/07/12