[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/11] linux-user/syscall: Remove unused variable from execve
From: |
Laurent Vivier |
Subject: |
Re: [PATCH 08/11] linux-user/syscall: Remove unused variable from execve |
Date: |
Tue, 13 Jul 2021 15:57:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
Le 12/07/2021 à 23:55, Richard Henderson a écrit :
> From clang-13:
> linux-user/syscall.c:8503:17: error: variable 'total_size' set but not used \
> [-Werror,-Wunused-but-set-variable]
>
> Cc: Laurent Vivier <laurent@vivier.eu>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> linux-user/syscall.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 2e826206d2..c27debba8c 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -8500,7 +8500,6 @@ static abi_long do_syscall1(void *cpu_env, int num,
> abi_long arg1,
> abi_ulong guest_envp;
> abi_ulong addr;
> char **q;
> - int total_size = 0;
>
> argc = 0;
> guest_argp = arg2;
> @@ -8532,7 +8531,6 @@ static abi_long do_syscall1(void *cpu_env, int num,
> abi_long arg1,
> break;
> if (!(*q = lock_user_string(addr)))
> goto execve_efault;
> - total_size += strlen(*q) + 1;
> }
> *q = NULL;
>
> @@ -8544,7 +8542,6 @@ static abi_long do_syscall1(void *cpu_env, int num,
> abi_long arg1,
> break;
> if (!(*q = lock_user_string(addr)))
> goto execve_efault;
> - total_size += strlen(*q) + 1;
> }
> *q = NULL;
>
>
Acked-by: Laurent Vivier <laurent@vivier.eu>
- Re: [PATCH 03/11] util/selfmap: Discard mapping on error, (continued)
- [PATCH 02/11] accel/tcg: Remove unused variable in cpu_exec, Richard Henderson, 2021/07/12
- [PATCH 07/11] hw/pci-hist/pnv_phb4: Fix typo in pnv_phb4_ioda_write, Richard Henderson, 2021/07/12
- [PATCH 05/11] hw/audio/adlib: Remove unused variable in adlib_callback, Richard Henderson, 2021/07/12
- [PATCH 06/11] hw/ppc/spapr_events: Remove unused variable from check_exception, Richard Henderson, 2021/07/12
- [PATCH 08/11] linux-user/syscall: Remove unused variable from execve, Richard Henderson, 2021/07/12
- Re: [PATCH 08/11] linux-user/syscall: Remove unused variable from execve,
Laurent Vivier <=
- [PATCH 11/11] tcg/ppc: Ensure _CALL_SYSV is set for 32-bit ELF, Richard Henderson, 2021/07/12
- [PATCH 09/11] tests/unit: Remove unused variable from test_io, Richard Henderson, 2021/07/12
- [PATCH 10/11] tcg/ppc: Replace TCG_TARGET_CALL_DARWIN with _CALL_DARWIN, Richard Henderson, 2021/07/12