Re: [PATCH 10/18] crypto: delete built-in XTS cipher mode support

[Eric Blake]

On Tue, Jul 06, 2021 at 10:59:16AM +0100, Daniel P. Berrangé wrote:
> The built-in AES+XTS implementation is used for the LUKS encryption
> When building system emulators it is reasonable to expect that an
> external crypto library is being used instead. The performance of the
> builtin XTS implementation is terrible as it has no CPU acceleration
> support. It is thus not worth keeping a home grown XTS implementation
> for the built-in cipher backend.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  crypto/cipher-builtin.c.inc | 60 -------------------------------------
>  crypto/meson.build          |  6 ++--
>  meson.build                 |  7 ++---
>  3 files changed, 6 insertions(+), 67 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org