Re: [PATCH 09/18] crypto: delete built-in DES implementation

[Eric Blake]

On Tue, Jul 06, 2021 at 10:59:15AM +0100, Daniel P. Berrangé wrote:
> The built-in DES implementation is used for the VNC server password
> authentication scheme. When building system emulators it is reasonable
> to expect that an external crypto library is being used. It is thus
> not worth keeping a home grown DES implementation in tree.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  crypto/cipher-builtin.c.inc |  72 -------
>  crypto/desrfb.c             | 416 ------------------------------------
>  crypto/meson.build          |   1 -
>  3 files changed, 489 deletions(-)
>  delete mode 100644 crypto/desrfb.c

Nice diffstat!

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org