[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 01/15] python/qom: Do not use 'err' name at module scope
|
From: |
Willian Rampazzo |
|
Subject: |
Re: [PATCH v3 01/15] python/qom: Do not use 'err' name at module scope |
|
Date: |
Wed, 30 Jun 2021 11:35:45 -0300 |
On Tue, Jun 29, 2021 at 6:43 PM John Snow <jsnow@redhat.com> wrote:
>
> Pylint updated to 2.9.0 upstream, adding new warnings for things that
> re-use the 'err' variable. Luckily, this only breaks the
> python-check-tox job, which is allowed to fail as a warning.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
>
> ---
>
> I guess that's good enough evidence that check-pipenv and check-tox both
> have their place :)
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/qmp/qom.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
- [PATCH v3 00/15] Python: packaging cleanups, John Snow, 2021/06/29
- [PATCH v3 02/15] python: expose typing information via PEP 561, John Snow, 2021/06/29
- [PATCH v3 01/15] python/qom: Do not use 'err' name at module scope, John Snow, 2021/06/29
- [PATCH v3 03/15] python: Remove global pylint suppressions, John Snow, 2021/06/29
- [PATCH v3 04/15] python: Re-lock pipenv at *oldest* supported versions, John Snow, 2021/06/29
- [PATCH v3 05/15] python: README.rst touchups, John Snow, 2021/06/29
- [PATCH v3 07/15] python: rename 'venv-check' target to 'check-pipenv', John Snow, 2021/06/29
- [PATCH v3 08/15] python: update help text for check-tox, John Snow, 2021/06/29
- [PATCH v3 06/15] python: Add no-install usage instructions, John Snow, 2021/06/29
- [PATCH v3 09/15] python: Fix .PHONY Make specifiers, John Snow, 2021/06/29
- [PATCH v3 10/15] python: only check qemu/ subdir with flake8, John Snow, 2021/06/29