Re: [PATCH v3 01/15] python/qom: Do not use 'err' name at module scope

[Wainer dos Santos Moschetta]

On 6/29/21 6:43 PM, John Snow wrote:
> Pylint updated to 2.9.0 upstream, adding new warnings for things that
> re-use the 'err' variable. Luckily, this only breaks the
> python-check-tox job, which is allowed to fail as a warning.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
>
> ---
>
> I guess that's good enough evidence that check-pipenv and check-tox both
> have their place :)
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   python/qemu/qmp/qom.py | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> diff --git a/python/qemu/qmp/qom.py b/python/qemu/qmp/qom.py
> index 7ec7843d57..8ff28a8343 100644
> --- a/python/qemu/qmp/qom.py
> +++ b/python/qemu/qmp/qom.py
> @@ -38,8 +38,8 @@
>   
>   try:
>       from .qom_fuse import QOMFuse
> -except ModuleNotFoundError as err:
> -    if err.name != 'fuse':
> +except ModuleNotFoundError as _err:
> +    if _err.name != 'fuse':
>           raise
>   else:
>       assert issubclass(QOMFuse, QOMCommand)