[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 12/29] tcg/ppc: Use power10 byte-reverse instructions
From: |
Bruno Piazera Larsen |
Subject: |
Re: [PATCH v3 12/29] tcg/ppc: Use power10 byte-reverse instructions |
Date: |
Mon, 28 Jun 2021 13:22:25 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 28/06/2021 11:45, Richard Henderson
wrote:
On
6/28/21 7:33 AM, Peter Maydell wrote:
+ if (have_isa_3_10) {
Side note, why do we call this have_isa_3_10 when it's checking
for ISA 3.1, not 3.10 ?
I think it's just because it made the columns line up:
#define have_isa_2_06 (have_isa >= tcg_isa_2_06)
#define have_isa_2_07 (have_isa >= tcg_isa_2_07)
#define have_isa_3_00 (have_isa >= tcg_isa_3_00)
#define have_isa_3_10 (have_isa >= tcg_isa_3_10)
though I think there's also a missing . or _ there -- should have
been 2.0.6 and 2.0.7.
No. The specifications in the Open Power foundation's websites
call the versions
2.07:
https://openpowerfoundation.org/?resource_lib=ibm-power-isa-version-2-07-b
and 2.06:
http://kib.kiev.ua/x86docs/POWER/PowerISA_V2.06B_V2_PUBLIC.pdf
Unless the PDFs also lost a . somewhere, which isn't impossible,
but I find more unlikely.
r~
- [PATCH v3 09/29] tcg/ppc: Split out tcg_out_bswap32, (continued)
- [PATCH v3 09/29] tcg/ppc: Split out tcg_out_bswap32, Richard Henderson, 2021/06/26
- [PATCH v3 11/29] tcg/ppc: Support bswap flags, Richard Henderson, 2021/06/26
- [PATCH v3 08/29] tcg/ppc: Split out tcg_out_bswap16, Richard Henderson, 2021/06/26
- [PATCH v3 04/29] tcg/aarch64: Support bswap flags, Richard Henderson, 2021/06/26
- [PATCH v3 10/29] tcg/ppc: Split out tcg_out_bswap64, Richard Henderson, 2021/06/26
- [PATCH v3 12/29] tcg/ppc: Use power10 byte-reverse instructions, Richard Henderson, 2021/06/26
- [PATCH v3 16/29] tcg/tci: Support bswap flags, Richard Henderson, 2021/06/26
- [PATCH v3 15/29] tcg/mips: Support bswap flags in tcg_out_bswap32, Richard Henderson, 2021/06/26
- [PATCH v3 20/29] tcg: Make use of bswap flags in tcg_gen_qemu_st_*, Richard Henderson, 2021/06/26
- [PATCH v3 25/29] target/sh4: Improve swap.b translation, Richard Henderson, 2021/06/26
- [PATCH v3 22/29] target/arm: Improve vector REV, Richard Henderson, 2021/06/26
- [PATCH v3 14/29] tcg/mips: Support bswap flags in tcg_out_bswap16, Richard Henderson, 2021/06/26
- [PATCH v3 17/29] tcg: Handle new bswap flags during optimize, Richard Henderson, 2021/06/26
- [PATCH v3 24/29] target/i386: Improve bswap translation, Richard Henderson, 2021/06/26
- [PATCH v3 19/29] tcg: Make use of bswap flags in tcg_gen_qemu_ld_*, Richard Henderson, 2021/06/26