[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 12/29] tcg/ppc: Use power10 byte-reverse instructions
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 12/29] tcg/ppc: Use power10 byte-reverse instructions |
Date: |
Mon, 28 Jun 2021 15:33:07 +0100 |
On Sat, 26 Jun 2021 at 07:41, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Cc: qemu-ppc@nongnu.org
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/ppc/tcg-target.c.inc | 34 ++++++++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> + if (have_isa_3_10) {
Side note, why do we call this have_isa_3_10 when it's checking
for ISA 3.1, not 3.10 ? The kernel calls its feature bit
#define PPC_FEATURE2_ARCH_3_1 0x00040000 /* ISA 3.1 */
but we seem to have gone for
#define PPC_FEATURE2_ARCH_3_10 0x00040000
in our elf.h.
thanks
-- PMM
- [PATCH v3 07/29] tcg/ppc: Split out tcg_out_sari{32,64}, (continued)
- [PATCH v3 07/29] tcg/ppc: Split out tcg_out_sari{32,64}, Richard Henderson, 2021/06/26
- [PATCH v3 02/29] tcg/i386: Support bswap flags, Richard Henderson, 2021/06/26
- [PATCH v3 09/29] tcg/ppc: Split out tcg_out_bswap32, Richard Henderson, 2021/06/26
- [PATCH v3 11/29] tcg/ppc: Support bswap flags, Richard Henderson, 2021/06/26
- [PATCH v3 08/29] tcg/ppc: Split out tcg_out_bswap16, Richard Henderson, 2021/06/26
- [PATCH v3 04/29] tcg/aarch64: Support bswap flags, Richard Henderson, 2021/06/26
- [PATCH v3 10/29] tcg/ppc: Split out tcg_out_bswap64, Richard Henderson, 2021/06/26
- [PATCH v3 12/29] tcg/ppc: Use power10 byte-reverse instructions, Richard Henderson, 2021/06/26
- Re: [PATCH v3 12/29] tcg/ppc: Use power10 byte-reverse instructions,
Peter Maydell <=
- [PATCH v3 16/29] tcg/tci: Support bswap flags, Richard Henderson, 2021/06/26
- [PATCH v3 15/29] tcg/mips: Support bswap flags in tcg_out_bswap32, Richard Henderson, 2021/06/26
- [PATCH v3 20/29] tcg: Make use of bswap flags in tcg_gen_qemu_st_*, Richard Henderson, 2021/06/26
- [PATCH v3 25/29] target/sh4: Improve swap.b translation, Richard Henderson, 2021/06/26
- [PATCH v3 22/29] target/arm: Improve vector REV, Richard Henderson, 2021/06/26
- [PATCH v3 14/29] tcg/mips: Support bswap flags in tcg_out_bswap16, Richard Henderson, 2021/06/26
- [PATCH v3 17/29] tcg: Handle new bswap flags during optimize, Richard Henderson, 2021/06/26