[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/15] softmmu/memory: Simplify access_with_adjusted_size int
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 07/15] softmmu/memory: Simplify access_with_adjusted_size interface |
Date: |
Mon, 21 Jun 2021 20:27:51 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
On 6/19/21 7:26 PM, Richard Henderson wrote:
> Create a typedef for the access_fn callback. Remove the
> access_size_{min,max} and access_fn arguments, and instead
> derive these from the MemoryRegion argument. Add a write
> boolean argument. Mark the function inline.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> softmmu/memory.c | 67 +++++++++++++++++++-----------------------------
> 1 file changed, 26 insertions(+), 41 deletions(-)
Nice simplification :)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- Re: [PATCH 04/15] accel/tcg: Don't test for watchpoints for code read, (continued)
- [PATCH 05/15] accel/tcg: Handle page span access before i/o access, Richard Henderson, 2021/06/19
- [PATCH 03/15] accel/tcg: Use byte ops for unaligned loads, Richard Henderson, 2021/06/19
- [PATCH 06/15] softmmu/memory: Inline memory_region_dispatch_read1, Richard Henderson, 2021/06/19
- [PATCH 02/15] accel/tcg: Extract load_helper_unaligned from load_helper, Richard Henderson, 2021/06/19
- [PATCH 08/15] hw/net/e1000e: Fix size of io operations, Richard Henderson, 2021/06/19
- [PATCH 09/15] hw/net/e1000e: Fix impl.min_access_size, Richard Henderson, 2021/06/19
- [PATCH 07/15] softmmu/memory: Simplify access_with_adjusted_size interface, Richard Henderson, 2021/06/19
- Re: [PATCH 07/15] softmmu/memory: Simplify access_with_adjusted_size interface,
Philippe Mathieu-Daudé <=
- [PATCH 11/15] hw/scsi/megasas: Fix megasas_mmio_ops sizes, Richard Henderson, 2021/06/19
- [PATCH 10/15] hw/pci-host/q35: Improve blackhole_ops, Richard Henderson, 2021/06/19
- [PATCH 13/15] softmmu/memory: Disallow short writes, Richard Henderson, 2021/06/19
- [PATCH 12/15] hw/scsi/megasas: Improve megasas_queue_ops min_access_size, Richard Henderson, 2021/06/19
- [PATCH 15/15] RFC accel/tcg: Defer some unaligned accesses to memory subsystem, Richard Henderson, 2021/06/19
- [PATCH 14/15] softmmu/memory: Support some unaligned access, Richard Henderson, 2021/06/19
- Re: [PATCH 00/15] accel/tcg: Fix for #360 and other i/o alignment issues, Mark Cave-Ayland, 2021/06/20
- Re: [PATCH 00/15] accel/tcg: Fix for #360 and other i/o alignment issues, Peter Maydell, 2021/06/20