[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 00/15] accel/tcg: Fix for #360 and other i/o alignment issues
From: |
Peter Maydell |
Subject: |
Re: [PATCH 00/15] accel/tcg: Fix for #360 and other i/o alignment issues |
Date: |
Sun, 20 Jun 2021 15:33:13 +0100 |
On Sat, 19 Jun 2021 at 18:28, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Short story is that the first two patches resolve the observed
> problem, by completely bypassing quite a lot of code in memory.c.
>
> Longer story is that we should either use that code in memory.c,
> or we should bypass it to an even lower level, so that we don't
> have multiple locations doing the partial-read assembly thing.
I haven't read the patchset yet, but my initial reaction is that
we ought to be handling this stuff in memory.c, because that
code is shared across all accelerators -- we would want the
same behaviour for accesses to a device that doesn't itself
handle a misalignment or a small access, whether we are using
TCG or KVM or HVF or whatever...
thanks
-- PMM
- [PATCH 07/15] softmmu/memory: Simplify access_with_adjusted_size interface, (continued)
- [PATCH 07/15] softmmu/memory: Simplify access_with_adjusted_size interface, Richard Henderson, 2021/06/19
- [PATCH 11/15] hw/scsi/megasas: Fix megasas_mmio_ops sizes, Richard Henderson, 2021/06/19
- [PATCH 10/15] hw/pci-host/q35: Improve blackhole_ops, Richard Henderson, 2021/06/19
- [PATCH 13/15] softmmu/memory: Disallow short writes, Richard Henderson, 2021/06/19
- [PATCH 12/15] hw/scsi/megasas: Improve megasas_queue_ops min_access_size, Richard Henderson, 2021/06/19
- [PATCH 15/15] RFC accel/tcg: Defer some unaligned accesses to memory subsystem, Richard Henderson, 2021/06/19
- [PATCH 14/15] softmmu/memory: Support some unaligned access, Richard Henderson, 2021/06/19
- Re: [PATCH 00/15] accel/tcg: Fix for #360 and other i/o alignment issues, Mark Cave-Ayland, 2021/06/20
- Re: [PATCH 00/15] accel/tcg: Fix for #360 and other i/o alignment issues,
Peter Maydell <=