qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/26] accel/tcg: Introduce translator_use_goto_tb


From: Richard Henderson
Subject: Re: [PATCH 01/26] accel/tcg: Introduce translator_use_goto_tb
Date: Mon, 21 Jun 2021 06:47:52 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 6/21/21 5:50 AM, Philippe Mathieu-Daudé wrote:
I notice various targets do:

#ifdef CONFIG_USER_ONLY
        return true;
#else

+    /* Check for the dest on the same page as the start of the TB.  */
+    return ((db->pc_first ^ dest) & TARGET_PAGE_MASK) == 0;
#endif

+}
Is that OK to remove this case? If so, it might be worth a comment
somewhere.

I mentioned it in the cover letter.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]