[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/26] target/arm: Use translator_use_goto_tb
From: |
Peter Maydell |
Subject: |
Re: [PATCH 05/26] target/arm: Use translator_use_goto_tb |
Date: |
Mon, 21 Jun 2021 11:20:32 +0100 |
On Mon, 21 Jun 2021 at 02:42, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Put a wrapper in translate.h, which also checks for ss_active.
> The ss_active test was incorrectly missing from the a32 version.
True, but we almost never call gen_goto_tb() when ss_active
(which makes sense because we generate code to raise a singlestep
exception instead). The only cases I think where we do call
gen_goto_tb() are ISB and SB; everything else calls gen_jmp_tb()
or otherwise handles the is_singlestepping() case.
thanks
-- PMM
- [PATCH 00/26] accel/tcg: Introduce translator_use_goto_tb, Richard Henderson, 2021/06/20
- [PATCH 01/26] accel/tcg: Introduce translator_use_goto_tb, Richard Henderson, 2021/06/20
- [PATCH 04/26] target/alpha: Use translator_use_goto_tb, Richard Henderson, 2021/06/20
- [PATCH 02/26] target/alpha: Remove use_exit_tb, Richard Henderson, 2021/06/20
- [PATCH 07/26] target/avr: Mark some helpers noreturn, Richard Henderson, 2021/06/20
- [PATCH 05/26] target/arm: Use translator_use_goto_tb, Richard Henderson, 2021/06/20
- Re: [PATCH 05/26] target/arm: Use translator_use_goto_tb,
Peter Maydell <=
- [PATCH 03/26] target/alpha: Remove in_superpage, Richard Henderson, 2021/06/20
- [PATCH 06/26] target/avr: Use translator_use_goto_tb, Richard Henderson, 2021/06/20
- [PATCH 09/26] target/hppa: Use translator_use_goto_tb, Richard Henderson, 2021/06/20
- [PATCH 10/26] target/i386: Use translator_use_goto_tb, Richard Henderson, 2021/06/20
- [PATCH 08/26] target/cris: Use translator_use_goto_tb, Richard Henderson, 2021/06/20
- [PATCH 11/26] target/m68k: Use translator_use_goto_tb, Richard Henderson, 2021/06/20
- [PATCH 12/26] target/microblaze: Use translator_use_goto_tb, Richard Henderson, 2021/06/20
- [PATCH 14/26] target/mips: Fix missing else in gen_goto_tb, Richard Henderson, 2021/06/20