Re: [PATCH v2 07/23] linux-user/cris: Implement setup_sigtramp

[Philippe Mathieu-Daudé]

On 6/19/21 2:55 PM, Richard Henderson wrote:
> On 6/19/21 2:33 AM, Philippe Mathieu-Daudé wrote:
>> On 6/18/21 9:29 PM, Richard Henderson wrote:
>>> Split out setup_sigreturn so that we can continue to
>>> initialize the words on the stack, as documented.
>>> However, use the off-stack trampoline.
>>>
>>> Cc: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>>> ---
>>>   linux-user/cris/target_signal.h |  2 ++
>>>   linux-user/cris/signal.c        | 29 +++++++++++++++++++++--------
>>>   2 files changed, 23 insertions(+), 8 deletions(-)
>>
>> Nitpicking, 6 -> 3 * 2? :)
> 
> Elsewhere I have used <bytes-per-tramp> * 2 if we have two trampolines,
> not <bytes-per-insn> * <n-insns>.

Oh, OK :)

>>
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>