[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 13/23] linux-user/mips: Tidy install_sigtramp
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 13/23] linux-user/mips: Tidy install_sigtramp |
Date: |
Sat, 19 Jun 2021 11:29:57 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
On 6/18/21 9:29 PM, Richard Henderson wrote:
> The return value is constant 0, and unused as well -- change to void.
> Drop inline marker. Change tramp type to uint32_t* for clarity.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> linux-user/mips/signal.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Thanks :)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH v2 00/23] linux-user: Move signal trampolines to new page, Richard Henderson, 2021/06/18
- [PATCH v2 01/23] linux-user: Add infrastructure for a signal trampoline page, Richard Henderson, 2021/06/18
- [PATCH v2 03/23] linux-user/arm: Split out v2_frame, Richard Henderson, 2021/06/18
- [PATCH v2 05/23] linux-user/arm: Implement setup_sigtramp, Richard Henderson, 2021/06/18
- [PATCH v2 02/23] linux-user/aarch64: Implement setup_sigtramp, Richard Henderson, 2021/06/18
- [PATCH v2 09/23] linux-user/hppa: Document non-use of setup_sigtramp, Richard Henderson, 2021/06/18
- [PATCH v2 06/23] linux-user/alpha: Implement setup_sigtramp, Richard Henderson, 2021/06/18
- [PATCH v2 04/23] linux-user/arm: Force v2 frames for fdpic, Richard Henderson, 2021/06/18
- [PATCH v2 13/23] linux-user/mips: Tidy install_sigtramp, Richard Henderson, 2021/06/18
- Re: [PATCH v2 13/23] linux-user/mips: Tidy install_sigtramp,
Philippe Mathieu-Daudé <=
- [PATCH v2 08/23] linux-user/hexagon: Implement setup_sigtramp, Richard Henderson, 2021/06/18
- [PATCH v2 07/23] linux-user/cris: Implement setup_sigtramp, Richard Henderson, 2021/06/18
- [PATCH v2 12/23] linux-user/microblaze: Implement setup_sigtramp, Richard Henderson, 2021/06/18
- [PATCH v2 16/23] linux-user/openrisc: Implement setup_sigtramp, Richard Henderson, 2021/06/18
- [PATCH v2 20/23] linux-user/sh4: Implement setup_sigtramp, Richard Henderson, 2021/06/18
- [PATCH v2 14/23] linux-user/mips: Implement setup_sigtramp, Richard Henderson, 2021/06/18