[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] target/riscv: csr: Remove redundant check in fp csr read
From: |
Bin Meng |
Subject: |
Re: [PATCH 2/2] target/riscv: csr: Remove redundant check in fp csr read/write routines |
Date: |
Tue, 15 Jun 2021 17:07:20 +0800 |
Hi Alistair,
On Wed, Mar 31, 2021 at 11:53 PM Alistair Francis <alistair23@gmail.com> wrote:
>
> On Tue, Mar 30, 2021 at 10:18 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> >
> > The following check:
> >
> > if (!env->debugger && !riscv_cpu_fp_enabled(env)) {
> > return -RISCV_EXCP_ILLEGAL_INST;
> > }
> >
> > is redundant in fflags/frm/fcsr read/write routines, as the check was
> > already done in fs().
> >
> > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
>
It looks like this patch was not applied anywhere?
Regards,
Bin
- Re: [PATCH 2/2] target/riscv: csr: Remove redundant check in fp csr read/write routines,
Bin Meng <=