Re: [PATCH 2/2] target/riscv: csr: Remove redundant check in fp csr read/write routines

[Alistair Francis]

On Tue, Jun 15, 2021 at 7:07 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Hi Alistair,
>
> On Wed, Mar 31, 2021 at 11:53 PM Alistair Francis <alistair23@gmail.com> 
> wrote:
> >
> > On Tue, Mar 30, 2021 at 10:18 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> > >
> > > The following check:
> > >
> > >     if (!env->debugger && !riscv_cpu_fp_enabled(env)) {
> > >         return -RISCV_EXCP_ILLEGAL_INST;
> > >     }
> > >
> > > is redundant in fflags/frm/fcsr read/write routines, as the check was
> > > already done in fs().
> > >
> > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> >
> > Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
> >
>
> It looks like this patch was not applied anywhere?

Nope, it doesn't appear to have been. Do you mind re-sending it?

Alistair

>
> Regards,
> Bin