qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/6] qapi/parser: Allow empty QAPIDoc Sections


From: John Snow
Subject: Re: [PATCH 2/6] qapi/parser: Allow empty QAPIDoc Sections
Date: Fri, 11 Jun 2021 13:21:56 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1

On 6/11/21 10:40 AM, Markus Armbruster wrote:
John Snow <jsnow@redhat.com> writes:

On 5/21/21 1:35 AM, Markus Armbruster wrote:
Does not fire for qga/qapi-schema.json.  Can you help?

Odd.

I did:

if self._section:
     ...
else:
     raise QAPIWhicheverErrorItWas(...)

and then did a full build and found it to fail on QGA stuff. You may
need --enable-docs to make it happen.

It later failed on test cases, too.

PEBKAC: I tested with a --disable-docs tree.  Disabled, because the
conversion to reST restored the "touch anything, rebuild everything" for
docs, which slows me down too much when I mess with the schema.

This snippet triggers the error:

     ##
     # @GuestExec:
     # @pid: pid of child process in guest OS
     #
     # Since: 2.5
     ##
     { 'struct': 'GuestExec',
       'data': { 'pid': 'int'} }

This one doesn't:

     ##
     # @GuestExec:
     #
     # @pid: pid of child process in guest OS
     #
     # Since: 2.5
     ##
     { 'struct': 'GuestExec',
       'data': { 'pid': 'int'} }

The code dealing with sections is pretty impenetrable.


Yeah, that's what I thought too. I might need (or want?) to touch this soon to do the cross-reference Sphinx stuff, so I figured I'd be coming back here "soon".

I could make a gitlab issue for me to track to remind myself to come back to it if you think that's acceptable.

--js




reply via email to

[Prev in Thread] Current Thread [Next in Thread]