Re: [PATCH 2/6] qapi/parser: Allow empty QAPIDoc Sections

[Markus Armbruster]

John Snow <jsnow@redhat.com> writes:

> On 5/21/21 1:35 AM, Markus Armbruster wrote:
>> Does not fire for qga/qapi-schema.json.  Can you help?
>
> Odd.
>
> I did:
>
> if self._section:
>     ...
> else:
>     raise QAPIWhicheverErrorItWas(...)
>
> and then did a full build and found it to fail on QGA stuff. You may
> need --enable-docs to make it happen.
>
> It later failed on test cases, too.

PEBKAC: I tested with a --disable-docs tree.  Disabled, because the
conversion to reST restored the "touch anything, rebuild everything" for
docs, which slows me down too much when I mess with the schema.

This snippet triggers the error:

    ##
    # @GuestExec:
    # @pid: pid of child process in guest OS
    #
    # Since: 2.5
    ##
    { 'struct': 'GuestExec',
      'data': { 'pid': 'int'} }

This one doesn't:

    ##
    # @GuestExec:
    #
    # @pid: pid of child process in guest OS
    #
    # Since: 2.5
    ##
    { 'struct': 'GuestExec',
      'data': { 'pid': 'int'} }

The code dealing with sections is pretty impenetrable.