Re: [PATCH 5/8] Fix incorrect initialization of PCI BARs.

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/8] Fix incorrect initialization of PCI BARs.

From:	Richard Henderson
Subject:	Re: [PATCH 5/8] Fix incorrect initialization of PCI BARs.
Date:	Sat, 5 Jun 2021 17:41:29 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 6/2/21 8:53 PM, Jason Thorpe wrote:

-         if ((val & PCI_BASE_ADDRESS_MEM_TYPE_MASK)
+         if ((old & PCI_BASE_ADDRESS_SPACE_IO) == 0 &&


The correct test is

  (old & PCI_BASE_ADDRESS_SPACE) == PCI_BASE_ADDRESS_SPACE_MEMORY

Bitwise it's the same thing. I'll fix it up while applying.


r~

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 3/8] Fix initialization of the hwrpb.hwrpb.cpuid field., (continued)
- [PATCH 1/8] Make qemu-palcode build environment standalone. NFC., Jason Thorpe, 2021/06/02
  - Re: [PATCH 1/8] Make qemu-palcode build environment standalone. NFC., Richard Henderson, 2021/06/05
- [PATCH 2/8] Fix delivery of unaligned access exceptions., Jason Thorpe, 2021/06/02
  - Re: [PATCH 2/8] Fix delivery of unaligned access exceptions., Richard Henderson, 2021/06/05
- [PATCH 4/8] Make some PCI macros available to other files. NFC., Jason Thorpe, 2021/06/02
  - Re: [PATCH 4/8] Make some PCI macros available to other files. NFC., Richard Henderson, 2021/06/05
- [PATCH 5/8] Fix incorrect initialization of PCI BARs., Jason Thorpe, 2021/06/02
  - Re: [PATCH 5/8] Fix incorrect initialization of PCI BARs., Philippe Mathieu-Daudé, 2021/06/03
    - Re: [PATCH 5/8] Fix incorrect initialization of PCI BARs., Jason Thorpe, 2021/06/04
  - Re: [PATCH 5/8] Fix incorrect initialization of PCI BARs., Richard Henderson <=
- [PATCH 6/8] Provide interrupt mapping information in PCI config registers., Jason Thorpe, 2021/06/02
  - Re: [PATCH 6/8] Provide interrupt mapping information in PCI config registers., Richard Henderson, 2021/06/05
- [PATCH 7/8] Provide a Console Terminal Block in the HWRPB., Jason Thorpe, 2021/06/02
  - Re: [PATCH 7/8] Provide a Console Terminal Block in the HWRPB., Richard Henderson, 2021/06/06
    - Re: [PATCH 7/8] Provide a Console Terminal Block in the HWRPB., Jason Thorpe, 2021/06/06
- [PATCH 8/8] Fixes for seconday CPU start-up., Jason Thorpe, 2021/06/02
  - Re: [PATCH 8/8] Fixes for seconday CPU start-up., Richard Henderson, 2021/06/06
- Re: [PATCH 0/8] PALcode fixes required to run NetBSD/alpha., Philippe Mathieu-Daudé, 2021/06/03
- Re: [PATCH 0/8] PALcode fixes required to run NetBSD/alpha., Richard Henderson, 2021/06/06

Prev by Date: Re: [PATCH 4/8] Make some PCI macros available to other files. NFC.
Next by Date: Re: [PATCH 6/8] Provide interrupt mapping information in PCI config registers.
Previous by thread: Re: [PATCH 5/8] Fix incorrect initialization of PCI BARs.
Next by thread: [PATCH 6/8] Provide interrupt mapping information in PCI config registers.
Index(es):
- Date
- Thread