qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/8] Fix incorrect initialization of PCI BARs.


From: Jason Thorpe
Subject: Re: [PATCH 5/8] Fix incorrect initialization of PCI BARs.
Date: Fri, 4 Jun 2021 11:23:23 -0700

> On Jun 3, 2021, at 2:24 AM, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> 
> Hi Jason,
> 
> On 6/3/21 5:53 AM, Jason Thorpe wrote:
>> Only program a BAR as a 64-bit MEM BAR if it really is a 64-bit MEM BAR.
>> Fixes an issue with the CMD646 IDE controller under NetBSD.
> 
> OK for this fix,
> 
>> 
>> Improve some debug/info messages.
> 
> but I'm not sure why you changed the format.
> Better split in 2 patches.

I'm not particularly wedded to the printf format changes.  I tweaked them when 
I was debugging the problem.  I'll update the patch with the printf format 
changes elided.

-- thorpej




reply via email to

[Prev in Thread] Current Thread [Next in Thread]