qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 5/9] qapi: Implement 'next-machine-phase' command


From: Paolo Bonzini
Subject: Re: [RFC PATCH 5/9] qapi: Implement 'next-machine-phase' command
Date: Sat, 5 Jun 2021 16:40:26 +0200



Il ven 4 giu 2021, 16:26 Eric Blake <eblake@redhat.com> ha scritto:
As an API, this command seems awkward.  How do I query what phase I'm
currently in?  How many times do I have to call it?  Do we anticipate
the number of times I need to call it to change in future qemu
releases?

Indeed this has been changed in the last version of the proposal. There will be an x-machine-init command and the existing x-exit-preconfig.

Paolo


Would it be better to require me to pass an enum parameter stating the
phase I intend to move into (and error out if that is not actually the
next phase), where the introspection of the enum tells me how many
times to use this command?  Should this command return a struct
containing "new-state":"enum-value" telling me what state I moved to
on success?


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


reply via email to

[Prev in Thread] Current Thread [Next in Thread]