|
From: | David Hildenbrand |
Subject: | Re: [PATCH v6 10/15] hostmem: Wire up RAM_NORESERVE via "reserve" property |
Date: | Fri, 23 Apr 2021 13:18:37 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
diff --git a/backends/hostmem.c b/backends/hostmem.c index c6c1ff5b99..58fdc1b658 100644 --- a/backends/hostmem.c +++ b/backends/hostmem.c @@ -217,6 +217,11 @@ static void host_memory_backend_set_prealloc(Object *obj, bool value, Error *local_err = NULL; HostMemoryBackend *backend = MEMORY_BACKEND(obj);+ if (!backend->reserve && value) {+ error_setg(errp, "'prealloc=on' and 'reserve=off' are incompatible"); + return; + }Aha. Shouldn't this be documented in qom.json?
Whoops, skipped that comment. Can add it if that's the place to document that.
-- Thanks, David / dhildenb
[Prev in Thread] | Current Thread | [Next in Thread] |