[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 07/15] util/mmap-alloc: Pass flags instead of separate boo
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v6 07/15] util/mmap-alloc: Pass flags instead of separate bools to qemu_ram_mmap() |
Date: |
Wed, 21 Apr 2021 14:37:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 4/21/21 2:26 PM, David Hildenbrand wrote:
> Let's pass flags instead of bools to prepare for passing other flags and
> update the documentation of qemu_ram_mmap(). Introduce new QEMU_MAP_
> flags that abstract the mmap() PROT_ and MAP_ flag handling and simplify
> it.
>
> We expose only flags that are currently supported by qemu_ram_mmap().
> Maybe, we'll see qemu_mmap() in the future as well that can implement these
> flags.
>
> Note: We don't use MAP_ flags as some flags (e.g., MAP_SYNC) are only
> defined for some systems and we want to always be able to identify
> these flags reliably inside qemu_ram_mmap() -- for example, to properly
> warn when some future flags are not available or effective on a system.
> Also, this way we can simplify PROT_ handling as well.
>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> include/qemu/mmap-alloc.h | 16 +++++++++-------
> include/qemu/osdep.h | 18 ++++++++++++++++++
> softmmu/physmem.c | 8 +++++---
> util/mmap-alloc.c | 15 ++++++++-------
> util/oslib-posix.c | 3 ++-
> 5 files changed, 42 insertions(+), 18 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH v6 00/15] RAM_NORESERVE, MAP_NORESERVE and hostmem "reserve" property, David Hildenbrand, 2021/04/21
- [PATCH v6 01/15] util/mmap-alloc: Factor out calculation of the pagesize for the guard page, David Hildenbrand, 2021/04/21
- [PATCH v6 02/15] util/mmap-alloc: Factor out reserving of a memory region to mmap_reserve(), David Hildenbrand, 2021/04/21
- [PATCH v6 04/15] softmmu/memory: Pass ram_flags to qemu_ram_alloc_from_fd(), David Hildenbrand, 2021/04/21
- [PATCH v6 03/15] util/mmap-alloc: Factor out activating of memory to mmap_activate(), David Hildenbrand, 2021/04/21
- [PATCH v6 05/15] softmmu/memory: Pass ram_flags to memory_region_init_ram_shared_nomigrate(), David Hildenbrand, 2021/04/21
- [PATCH v6 06/15] softmmu/memory: Pass ram_flags to qemu_ram_alloc() and qemu_ram_alloc_internal(), David Hildenbrand, 2021/04/21
- [PATCH v6 07/15] util/mmap-alloc: Pass flags instead of separate bools to qemu_ram_mmap(), David Hildenbrand, 2021/04/21
- Re: [PATCH v6 07/15] util/mmap-alloc: Pass flags instead of separate bools to qemu_ram_mmap(),
Philippe Mathieu-Daudé <=
- [PATCH v6 09/15] util/mmap-alloc: Support RAM_NORESERVE via MAP_NORESERVE under Linux, David Hildenbrand, 2021/04/21
- [PATCH v6 10/15] hostmem: Wire up RAM_NORESERVE via "reserve" property, David Hildenbrand, 2021/04/21
- Re: [PATCH v6 10/15] hostmem: Wire up RAM_NORESERVE via "reserve" property, Markus Armbruster, 2021/04/23
- Re: [PATCH v6 10/15] hostmem: Wire up RAM_NORESERVE via "reserve" property, David Hildenbrand, 2021/04/23
- Re: [PATCH v6 10/15] hostmem: Wire up RAM_NORESERVE via "reserve" property, Markus Armbruster, 2021/04/23
- Re: [PATCH v6 10/15] hostmem: Wire up RAM_NORESERVE via "reserve" property, David Hildenbrand, 2021/04/23
- Re: [PATCH v6 10/15] hostmem: Wire up RAM_NORESERVE via "reserve" property, Markus Armbruster, 2021/04/23
[PATCH v6 08/15] memory: Introduce RAM_NORESERVE and wire it up in qemu_ram_mmap(), David Hildenbrand, 2021/04/21