[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 08/30] target/mips: Declare mips_cpu_set_error_pc() inline

From: Richard Henderson
Subject: Re: [PATCH v3 08/30] target/mips: Declare mips_cpu_set_error_pc() inlined in "internal.h"
Date: Tue, 20 Apr 2021 07:03:44 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 4/19/21 1:42 PM, Philippe Mathieu-Daudé wrote:
On 4/19/21 9:27 PM, Richard Henderson wrote:
On 4/19/21 12:18 PM, Philippe Mathieu-Daudé wrote:
Rename set_pc() as mips_cpu_set_error_pc(), declare it inlined
and use it in cpu.c and op_helper.c.

Why "error_pc"?  The usage in mips_cpu_set_pc certainly isn't in
response to any kind of error...

Indeed, but I couldn't find any good name. mips_cpu_set_pc() is
already taken, as is cpu_set_pc():

static void mips_cpu_set_pc(CPUState *cs, vaddr value)

mips_cpu_state_set_pc() maybe?

mips_env_set_pc?  Since cs vs env is the only difference...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]