[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/5] qemu-iotests: quality of life improvements
From: |
Max Reitz |
Subject: |
Re: [PATCH v2 0/5] qemu-iotests: quality of life improvements |
Date: |
Fri, 26 Mar 2021 14:40:22 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 23.03.21 19:19, Paolo Bonzini wrote:
This series adds a few usability improvements to qemu-iotests, in
particular:
- arguments can be passed to Python unittests scripts, for example
to run only a subset of the test cases (patches 1-2)
- it is possible to do "./check -- ../../../tests/qemu-iotests/055 args..."
and specify arbitrary arguments to be passed to a single test script.
This allows to take advantage of the previous feature and ease debugging
of Python tests.
Paolo
v1->v2: patches 1-2 are a rewrite of v1's patch 1
moved print_env change to patch 4
do not use argparse.REMAINDER
I’m afraid the changes to iotests.py don’t pass the scrutiny of iotest
297, so I’m going to have to remove the series again. :/
=== pylint ===
************* Module iotests
iotests.py:1288:0: R0205: Class 'ReproducibleStreamWrapper' inherits
from object, can be safely removed from bases in python3
(useless-object-inheritance)
iotests.py:1303:4: W1113: Keyword argument before variable positional
arguments list in the definition of __init__ function
(keyword-arg-before-vararg)
=== mypy ===
iotests.py:1303: error: Function is missing a type annotation for one or
more arguments
iotests.py:1304: error: Missing type parameters for generic type "Type"
iotests.py:1311: error: Function is missing a return type annotation
Found 3 errors in 1 file (checked 1 source file)
iotests.py:1303: error: Function is missing a type annotation for one or
more arguments
iotests.py:1304: error: Missing type parameters for generic type "Type"
iotests.py:1311: error: Function is missing a return type annotation
Found 3 errors in 1 file (checked 1 source file)
iotests.py:1303: error: Function is missing a type annotation for one or
more arguments
iotests.py:1304: error: Missing type parameters for generic type "Type"
iotests.py:1311: error: Function is missing a return type annotation
Found 3 errors in 1 file (checked 1 source file)
iotests.py:1303: error: Function is missing a type annotation for one or
more arguments
iotests.py:1304: error: Missing type parameters for generic type "Type"
iotests.py:1311: error: Function is missing a return type annotation
Found 3 errors in 1 file (checked 1 source file)
iotests.py:1303: error: Function is missing a type annotation for one or
more arguments
iotests.py:1304: error: Missing type parameters for generic type "Type"
iotests.py:1311: error: Function is missing a return type annotation
Found 3 errors in 1 file (checked 1 source file)
iotests.py:1303: error: Function is missing a type annotation for one or
more arguments
iotests.py:1304: error: Missing type parameters for generic type "Type"
iotests.py:1311: error: Function is missing a return type annotation
Found 3 errors in 1 file (checked 1 source file)
iotests.py:1303: error: Function is missing a type annotation for one or
more arguments
iotests.py:1304: error: Missing type parameters for generic type "Type"
iotests.py:1311: error: Function is missing a return type annotation
Found 3 errors in 1 file (checked 1 source file)
iotests.py:1303: error: Function is missing a type annotation for one or
more arguments
iotests.py:1304: error: Missing type parameters for generic type "Type"
iotests.py:1311: error: Function is missing a return type annotation
Found 3 errors in 1 file (checked 1 source file)
- Re: [PATCH v2 4/5] qemu-iotests: let "check" spawn an arbitrary test command, (continued)
[PATCH v2 5/5] qemu-iotests: fix case of SOCK_DIR already in the environment, Paolo Bonzini, 2021/03/23
[PATCH v2 1/5] qemu-iotests: do not buffer the test output, Paolo Bonzini, 2021/03/23
[PATCH v2 3/5] qemu-iotests: move command line and environment handling from TestRunner to TestEnv, Paolo Bonzini, 2021/03/23
Re: [PATCH v2 0/5] qemu-iotests: quality of life improvements, Emanuele Giuseppe Esposito, 2021/03/24
Re: [PATCH v2 0/5] qemu-iotests: quality of life improvements, Max Reitz, 2021/03/25
Re: [PATCH v2 0/5] qemu-iotests: quality of life improvements,
Max Reitz <=