|
From: | Paolo Bonzini |
Subject: | Re: [PATCH v2 4/5] qemu-iotests: let "check" spawn an arbitrary test command |
Date: | Tue, 23 Mar 2021 22:20:46 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 23/03/21 20:12, Vladimir Sementsov-Ogievskiy wrote:
Move the trailing empty line to print_env(), since it always looks better and one caller was not adding it.Seems you've moved this fix from one unrelated commit to another.. And it touches two extra files. I'd just make it a separate commit. Nitpicking. Separate or as is:
Well, now I add the third caller so it's time to make up our mind on the trailing line. A two-line commit didn't seem worth it.
Paolo
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
[Prev in Thread] | Current Thread | [Next in Thread] |