|
| From: | Richard Henderson |
| Subject: | Re: [PATCH 15/15] Hexagon (target/hexagon) CABAC decode bin |
| Date: | Thu, 25 Mar 2021 10:54:39 -0600 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 |
On 3/24/21 8:50 PM, Taylor Simpson wrote:
+#define fINSERT_RANGE(INREG, HIBIT, LOWBIT, INVAL) \ + INREG = (((HIBIT) - (LOWBIT) - 1) ? \ + deposit64((INREG), (LOWBIT), ((HIBIT) - (LOWBIT) + 1), (INVAL)) : \ + INREG)
The -1 and +1 on the length of the field doesn't look right. Which really computes the length of the field? Did you in fact want the test to be HIBIT >= LOBIT? r~
| [Prev in Thread] | Current Thread | [Next in Thread] |