qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 05/15] Hexagon (target/hexagon) change variables from int to


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 05/15] Hexagon (target/hexagon) change variables from int to bool when appropriate
Date: Thu, 25 Mar 2021 10:35:21 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0

Hi Taylor,

On 3/25/21 3:50 AM, Taylor Simpson wrote:
> Address feedback from Richard Henderson <richard.henderson@linaro.org>

If you look at the git history, we use the following tags:
- Reported-by: Richard Henderson <richard.henderson@linaro.org>
- Suggested-by: Richard Henderson <richard.henderson@linaro.org>
and tools know how to use them:
https://repo.or.cz/git-dm.git/blob/5ccc4dac6837:/gitdm#l292
(same comment applies to other patches in your series).

That said,
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> 
> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> ---
>  target/hexagon/cpu_bits.h  |  2 +-
>  target/hexagon/decode.c    | 80 
> +++++++++++++++++++++++-----------------------
>  target/hexagon/insn.h      | 21 ++++++------
>  target/hexagon/op_helper.c |  8 ++---
>  target/hexagon/translate.c |  6 ++--
>  target/hexagon/translate.h |  2 +-
>  6 files changed, 60 insertions(+), 59 deletions(-)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]