qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v11 13/55] target/arm: split cpregs from tcg/helper.c


From: Richard Henderson
Subject: Re: [RFC v11 13/55] target/arm: split cpregs from tcg/helper.c
Date: Wed, 24 Mar 2021 12:40:27 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 3/23/21 9:45 AM, Claudio Fontana wrote:
give them their own common module cpregs.c, and an interface cpregs.h.
Extract the raw cpustate list to its own module.
This is more or less needed for KVM too.

For the tcg-specific registers, stuff them into tcg/cpregs.c

As a result, the monster that is tcg/helper.c is a bit less scary,
and a lot of stuff is removed from cpu.h too, relegated to cpregs.h.

Signed-off-by: Claudio Fontana<cfontana@suse.de>
---

I would expect ARM_CP_* to move out of cpu.h.

I don't see any use of the ARMCPRegInfo typedef remaining in cpu.h. Surely that should move to the new header.

Otherwise, it's really nice to get so many lines out of helper.c.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]